Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CLIEngine with ESLint #25801

Conversation

matamatanot
Copy link
Contributor

@matamatanot matamatanot commented Jun 5, 2021

@ijjk

This comment has been hidden.

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Jun 9, 2021

Thanks!

@ijjk
Copy link
Member

@ijjk ijjk commented Jun 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
buildDuration 10.6s 11.1s ⚠️ +421ms
buildDurationCached 2.6s 2.6s -2ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
/ failed reqs 0 0
/ total time (seconds) 2.205 2.184 -0.02
/ avg req/sec 1133.94 1144.53 +10.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.114 1.125 ⚠️ +0.01
/error-in-render avg req/sec 2243.27 2222.01 ⚠️ -21.26
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
index.php gzip 572 B 572 B
link.html gzip 581 B 581 B
withRouter.html gzip 568 B 568 B
Overall change 1.72 kB 1.72 kB

Serverless Mode
General
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
buildDuration 12.2s 11.9s -242ms
buildDurationCached 3.5s 3.5s ⚠️ +51ms
nodeModulesSize 46.5 MB 46.5 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 20.2 kB 20.2 kB
webpack-HASH.js gzip 804 B 804 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
_app-HASH.js gzip 801 B 801 B
_error-HASH.js gzip 3.07 kB 3.07 kB
amp-HASH.js gzip 527 B 527 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 333 B 333 B
withRouter-HASH.js gzip 330 B 330 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
_buildManifest.js gzip 392 B 392 B
Overall change 392 B 392 B
Serverless bundles
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
_error.js 16.9 kB 16.9 kB
404.html 2.44 kB 2.44 kB
500.html 2.43 kB 2.43 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.63 kB 1.63 kB
css.html 1.81 kB 1.81 kB
hooks.html 1.69 kB 1.69 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
buildDuration 9.5s 9.5s -61ms
buildDurationCached 3.8s 3.9s ⚠️ +58ms
nodeModulesSize 46.5 MB 46.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
/ failed reqs 0 0
/ total time (seconds) 2.176 2.207 ⚠️ +0.03
/ avg req/sec 1148.79 1132.71 ⚠️ -16.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.102 1.144 ⚠️ +0.04
/error-in-render avg req/sec 2267.95 2184.73 ⚠️ -83.22
Client Bundles (main, webpack, commons)
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.99 kB 7.99 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 61.1 kB 61.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
_app-HASH.js gzip 1.07 kB 1.07 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.63 kB 1.63 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.17 kB 9.17 kB
Client Build Manifests
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary matamatanot/next.js remove-CLIEngine-with-ESLint-because-of-deprecated Change
index.php gzip 626 B 626 B
link.html gzip 632 B 632 B
withRouter.html gzip 619 B 619 B
Overall change 1.88 kB 1.88 kB
Commit: 42e4a6d

@ijjk
Copy link
Member

@ijjk ijjk commented Jun 9, 2021

Failing test suites

Commit: 42e4a6d

test/integration/basic/test/index.test.js

  • Basic Features > Hot Module Reloading > editing a page > should update styles correctly
Expand output

● Basic Features › Hot Module Reloading › editing a page › should update styles correctly

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":".hmr-style-page p"}
  (Session info: headless chrome=91.0.4472.77)

  149 |         try {
  150 |           browser = await webdriver(context.appPort, '/hmr/style')
> 151 |           const pTag = await browser.elementByCss('.hmr-style-page p')
      |                        ^
  152 |           const initialFontSize = await pTag.getComputedCss('font-size')
  153 |
  154 |           expect(initialFontSize).toBe('100px')

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/basic/test/hmr.js:151:24)

@timneutkens timneutkens merged commit 3821662 into vercel:canary Jun 9, 2021
24 of 30 checks passed
@matamatanot matamatanot deleted the remove-CLIEngine-with-ESLint-because-of-deprecated branch Jun 9, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this issue Jun 16, 2021
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants