Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify output messages #31454

Merged
merged 5 commits into from Nov 16, 2021
Merged

simplify output messages #31454

merged 5 commits into from Nov 16, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 15, 2021

remove all client/server/middleware only messages and show client and server instead only when both compilers has been used.

@ijjk

This comment has been hidden.

@ijjk

This comment has been hidden.

timneutkens
timneutkens previously approved these changes Nov 15, 2021
@ijjk

This comment has been hidden.

@ijjk
Copy link
Member

@ijjk ijjk commented Nov 15, 2021

Failing test suites

Commit: 4342fa2

test/integration/nullish-config/test/index.test.js

  • Nullish configs in next.config.js > dev mode > should ignore configs set to null in next.config.js
Expand output

● Nullish configs in next.config.js › dev mode › should ignore configs set to null in next.config.js

expect(received).toContain(expected) // indexOf

Expected substring: "ompiled successfully"
Received string:    "ready - started server on 0.0.0.0:40315, url: http://localhost:40315
event - compiled client and server successfully in 3.9s (159 modules)
"

  40 |           webpack: null,
  41 |           pageExtensions: null,
> 42 |           amp: {
     |                 ^
  43 |             canonicalBase: null,
  44 |           },
  45 |         }

  at Object.<anonymous> (integration/nullish-config/test/index.test.js:42:24)

@ijjk

This comment has been hidden.

ijjk
ijjk approved these changes Nov 16, 2021
@ijjk
Copy link
Member

@ijjk ijjk commented Nov 16, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
buildDuration 25.2s 24.9s -250ms
buildDurationCached 4.8s 4.7s -49ms
nodeModulesSize 336 MB 336 MB -360 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
/ failed reqs 0 0
/ total time (seconds) 4.09 4.131 ⚠️ +0.04
/ avg req/sec 611.21 605.14 ⚠️ -6.07
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.234 2.237 0
/error-in-render avg req/sec 1118.99 1117.75 ⚠️ -1.24
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
index.php gzip 523 B 523 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
buildDuration 26.6s 26.3s -289ms
buildDurationCached 4.9s 4.8s -132ms
nodeModulesSize 336 MB 336 MB -360 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
/ failed reqs 0 0
/ total time (seconds) 4.23 4.132 -0.1
/ avg req/sec 591.03 604.97 +13.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.148 2.18 ⚠️ +0.03
/error-in-render avg req/sec 1163.95 1146.77 ⚠️ -17.18
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/middleware-only Change
index.php gzip 524 B 524 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: d61c6c2

@kodiakhq kodiakhq bot merged commit b79591c into canary Nov 16, 2021
40 checks passed
@kodiakhq kodiakhq bot deleted the bugfix/middleware-only branch Nov 16, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants